Add each_with_index to Performance/ReverseEach cop#522
Open
Babar wants to merge 1 commit intorubocop:masterfrom
Open
Add each_with_index to Performance/ReverseEach cop#522Babar wants to merge 1 commit intorubocop:masterfrom
Babar wants to merge 1 commit intorubocop:masterfrom
Conversation
`revese.each_with_index` has the exact same behavior as `reverse.each`, therefore add it to the cop too
d130d42 to
ae874d2
Compare
Author
|
Found a computer which could actually run |
Author
|
@koic can you please allow the tests to run so I can confirm this PR is ready? They worked on my machine, but it's only one data point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revese.each_with_indexhas the exact same behavior asreverse.each, therefore add it to the cop tooReplace this text with a summary of the changes in your PR.
The more detailed you are, the better.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.