cross navigator preemption#6018
Open
avanmalleghem wants to merge 9 commits intoros-navigation:mainfrom
Open
Conversation
When a new navigation goal arrives while a different navigator is already running, stop the current navigator and wait for it to fully complete before accepting the new goal, instead of rejecting it. Signed-off-by: avanmalleghem <antoine.vanmalleghem@botronics.be>
Signed-off-by: avanmalleghem <antoine.vanmalleghem@botronics.be>
5bedd2a to
19c79b1
Compare
Codecov Report❌ Patch coverage is
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Member
|
@avanmalleghem do you want me to review? |
Author
|
@SteveMacenski not yet, would like to go deeper in testing before :) I keep you in touch |
Author
parameter.to.true.webm@SteveMacenski a small video of the expected result :) This PR can be reviewed now... I made a lot of tests in simulation but don't see how I could integrate UT without refactoring code. |
nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: avanmalleghem <antoine.vanmalleghem@botronics.be>
nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server.hpp
Outdated
Show resolved
Hide resolved
nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server_impl.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Antoine Van Malleghem <a.vanmalleghem@gmail.com>
…when starting executing instead of after Signed-off-by: avanmalleghem <antoine.vanmalleghem@botronics.be>
Signed-off-by: avanmalleghem <antoine.vanmalleghem@botronics.be>
Signed-off-by: avanmalleghem <antoine.vanmalleghem@botronics.be>
Signed-off-by: avanmalleghem <antoine.vanmalleghem@botronics.be>
nav2_behavior_tree/include/nav2_behavior_tree/bt_action_server.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: avanmalleghem <antoine.vanmalleghem@botronics.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
allow_navigator_preemptionparameter allows you to start another navigator while another one is running. It will cancel the first one, wait until it is cancelled and then start the new one. Parameter set to false by default so that you keep the current behavior (reject).internal_cancel_requested_getCurrentNavigatorcurrent_navigator_is now a navigator type and not only a string containing its name.Description of documentation updates required from your changes
allow_navigator_preemptionparameter addedDescription of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.