Make unwrapExports only pick out default when it exists#226
Make unwrapExports only pick out default when it exists#226lukastaegert merged 1 commit intorollup:masterfrom marijnh:master
Conversation
|
Heyyy there 👋, any chance this could get a look? |
|
Hi @marijnh, sorry you have been waiting for so long. I just took a look at your change and to me it seems that this should work well in all cases 👍. However, as this issue is somewhat non-trivial, could you add a test that is fixed by your change? Something like what you posted as an example in #224 should be fine. This is important as it If you don't feel up to it, I can do it for you, but this is your PR after all 😉 |
|
Good point. I've updated the commit to include a test. |
|
Until @Rich-Harris is back at the internet to publish a new version, you can install a version containing this fix via npm install github:rollup-plugin-commonjs@rollup/rollup-plugin-commonjs#bundled-v8.2.3which should contain all necessary build artefacts. |
|
|
We need the fix for rollup/rollup-plugin-commonjs#226.
Now that I'm actually awake, I think it's rather obvious how issue #224 should be solved. Take a look!