Open
Conversation
rfjakob
requested changes
Jan 7, 2026
Contributor
Author
|
This is my 1st MR to really big project. I don't understand what I need do next. Do I need click Resolve conversation for line 68 and return your code instead of 61-62 lines? |
Owner
|
Yes change back to original code for lines 61-62, then "git commit -a --amend" and "git push --force" |
use maps and slices instead of explicit for loop
Contributor
Author
|
Something else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use maps and slices instead of explicit for-loop