Skip to content

🔒 ci(workflows): add zizmor security auditing#217

Merged
gaborbernat merged 1 commit intopytest-dev:mainfrom
gaborbernat:add-zizmor-pre-commit
Mar 24, 2026
Merged

🔒 ci(workflows): add zizmor security auditing#217
gaborbernat merged 1 commit intopytest-dev:mainfrom
gaborbernat:add-zizmor-pre-commit

Conversation

@gaborbernat
Copy link
Collaborator

@gaborbernat gaborbernat commented Mar 24, 2026

GitHub Actions workflows were vulnerable to several security issues including template injection, credential exposure, and permission over-scoping. These vulnerabilities could allow attackers to execute arbitrary code or access sensitive tokens.

This change adds zizmor as a pre-commit hook to continuously audit workflow security and fixes all existing vulnerabilities. The fixes include pinning actions to commit hashes, moving secrets to dedicated environments, isolating GitHub context from shell execution, and restricting permissions to the minimum required scope.

All workflows now pass security audit with zero findings. Future workflow changes will be automatically checked before commit.

@gaborbernat gaborbernat force-pushed the add-zizmor-pre-commit branch from ff02ef6 to 5549b19 Compare March 24, 2026 23:07
Add zizmor pre-commit hook to catch GitHub Actions security issues.
Fix all existing findings:
- template-injection: Move GitHub context to env vars
- secrets-outside-env: Add environment declarations
- dangerous-triggers: Replace pull_request_target with pull_request
- bot-conditions: Use pull_request.user.login instead of github.actor
- excessive-permissions: Move permissions to job level
- superfluous-actions: Replace with native tools
@gaborbernat gaborbernat force-pushed the add-zizmor-pre-commit branch from 5549b19 to c08992d Compare March 24, 2026 23:14
@gaborbernat gaborbernat changed the title Add zizmor pre-commit hook and fix security issues 🔒 ci(workflows): add zizmor security auditing Mar 24, 2026
@gaborbernat gaborbernat merged commit 21e8505 into pytest-dev:main Mar 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant