Support ip[6]tables protocol in firewallchain#1191
Merged
malikparvez merged 1 commit intopuppetlabs:mainfrom Sep 23, 2024
Merged
Support ip[6]tables protocol in firewallchain#1191malikparvez merged 1 commit intopuppetlabs:mainfrom
malikparvez merged 1 commit intopuppetlabs:mainfrom
Conversation
|
Subscribing... my ipv6 rules fail as well: |
Collaborator
|
@jcharaoui can you please rebase against main to get rid of the merge commit? |
a9c0fb5 to
56367a7
Compare
Contributor
Author
Done! |
|
Hi ! I just tested this and was able to get my IPv6 rules working as expected with this fix.. Otherwise it would not. Thanks in advance ! In the meantime I'll just clone the module and make the fix locally. |
This mirrors the values accepted for the firewall provider.
56367a7 to
aa1fd48
Compare
malikparvez
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This mirrors the values accepted for the firewall provider.
Additional Context
If a
firewallchainresource is defined withprotocol => 'ip6tables', this fails with errorExecution of '' returned 1: Error: Could not execute posix command: no implicit conversion of nil into StringChecklist
puppet apply)