every chardet package maps to requests.packages.chardet.* package respectively#6562
Merged
sigmavirus24 merged 4 commits intopsf:mainfrom Feb 23, 2024
Merged
every chardet package maps to requests.packages.chardet.* package respectively#6562sigmavirus24 merged 4 commits intopsf:mainfrom
sigmavirus24 merged 4 commits intopsf:mainfrom
Conversation
Contributor
|
Your PR as is will still have the same issue you reported and does not fix it. I've added a suggestion |
Co-authored-by: Ian Stapleton Cordasco <graffatcolmingov@gmail.com>
Contributor
Author
|
Same checks are failing on the main branch - #6566 I think the issue is with werkzeug latest version which gets downloaded due to dependency with |
Contributor
Author
|
Is there anything more required in this PR to be merged? Or is it on standby until the httpbin issue gets resolved @sigmavirus24 |
Contributor
|
closing & reopening to trigger new build |
sigmavirus24
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a fix for the issue mentioned here - #6223
Checked in the code, only one package of chardet was being mapped to requests.packages.chardet despite the for loop.
Have added the fix so each chardet package maps to it's corresponding requests.packages.chardet.* respectively.