Attempt on fixing abort events for fetch()#42
Merged
trek merged 2 commits intopretenderjs:masterfrom Oct 29, 2018
Merged
Conversation
raido
force-pushed
the
fix-aborting-event-order
branch
from
2b3f4b7 to
bb308d2
Compare
raido
commented
Sep 13, 2018
src/fake-xml-http-request.js
Outdated
| this.dispatchEvent(new _Event("load", false, false, this)); | ||
| this.dispatchEvent(new _Event("loadend", false, false, this)); | ||
| } | ||
| this.dispatchEvent(new _Event("loadend", false, false, this)); |
Contributor
Author
There was a problem hiding this comment.
This is actually bug now, because every time _readyStateChange is called this "loadend" gets dispatched. For example FakeXMLHttpRequest.OPEN is dispatched and follows with loadend.
Contributor
Author
|
any chance of releasing v2.0.1 to npm? I think I need this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #41 hopefully.