Fixes queryRecord issue #148#152
Conversation
|
Just a note, the warnings were added in Ember Data 2.6.0. |
|
@dweremeichik maybe this helps to make it backwards compatible. |
|
@dweremeichik We started testing from Ember 2.4 and I tried in https://github.com/broerse/ember-pouch/tree/queryRecord to fix this PR but your added test still fails. Do you have time to take a look and fix your PR. I like to merge this. |
|
@broerse, haven't used ember-pouch in a while. However it used to build in 2.4 without issue. May have something to do with the tests changing when the hasmany "split tests" were added. |
|
Also, a brief look at the logs tells me it only breaks when the tests are "sync" not sure what that feature is, added after my initial PR, must be. |
jlami
left a comment
jlami
left a comment
There was a problem hiding this comment.
I think these changes will fix the failing test
| queryRecord: function(store, type, query) { | ||
| return this.query(store, type, query); | ||
| return this.query(store, type, query).then(results => { | ||
| let result = {}; |
There was a problem hiding this comment.
You need to edit the original results object. Since this can have additional entries, which are sideloaded.
| result[recordType] = results[pluralize(recordType)][0]; | ||
| } else { | ||
| result[recordType] = null; | ||
| } |
There was a problem hiding this comment.
after using the singular recordType to set the expected single item, you need to delete results[pluralize(recordType)]; to remove the plural entry
|
@dweremeichik this PR fixed the failing tests. 86601e6 |
4 participants
This fixes issue #148, and removes the following warning:
DEPRECATION: The adapter returned an array for the primary data of a
queryRecordresponse. This is deprecated asqueryRecordshould return a single record. [deprecation id: ds.serializer.rest.queryRecord-array-response]Note:
until: '3.0'.queryRecordwas just an alias forquerypreviously this would be a non-backward compatible change.