Merged
Conversation
adamcooke
force-pushed
the
remove-moonrope
branch
2 times, most recently
from
21f4849 to
5bae898
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| class BaseController < ActionController::Base | ||
|
|
||
| skip_before_action :set_browser_id | ||
| skip_before_action :verify_authenticity_token |
Check failure
Code scanning / CodeQL
CSRF protection weakened or disabled
adamcooke
force-pushed
the
remove-moonrope
branch
4 times, most recently
from
3f319ee to
a62e163
Compare
adamcooke
force-pushed
the
remove-moonrope
branch
from
a62e163 to
896f019
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependency on Moonrope for the API. This API is going to be deprecated shortly in favour of the new API which will be powered by Apia and before doing that removing some of this old debt is worthwhile.
This reproduces the same behaviour of the API using standard Rails controllers. I anticipate on keeping these endpoints live until at least Postal v5.