Uninitialized local variable in terminal_size#92
Merged
p-ranav merged 1 commit intop-ranav:masterfrom Mar 18, 2021
turuslan:fix/terminal_size
Merged
Uninitialized local variable in terminal_size#92p-ranav merged 1 commit intop-ranav:masterfrom turuslan:fix/terminal_size
p-ranav merged 1 commit intop-ranav:masterfrom
turuslan:fix/terminal_size
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MacOS
ioctldoesn't fill size structure for non-ttyfd.In such case
terminal_sizereturns random value from stack.P.S. I found this when I used
ProgressBarwithoption::Completed{terminal_width() == 0}to add newlines when stdout is piped.