Skip to content

Add support for nginx 1.28.1#1011

Merged
lucacome merged 1 commit intoopentracing-contrib:masterfrom
abridgel:add-nginx-1.28.1-support
Jan 14, 2026
Merged

Add support for nginx 1.28.1#1011
lucacome merged 1 commit intoopentracing-contrib:masterfrom
abridgel:add-nginx-1.28.1-support

Conversation

@abridgel
Copy link
Copy Markdown
Contributor

@abridgel abridgel commented Jan 14, 2026

This PR adds nginx 1.28.1 to the CI build matrix for building binaries.

Summary by CodeRabbit

  • Chores
    • Expanded nginx version matrix in CI pipeline testing to include additional version coverage.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 14, 2026

Walkthrough

Added NGINX version 1.28.1 to the Build Binaries CI workflow's nginx_version matrix, extending the set of NGINX versions tested during the build process.

Changes

Cohort / File(s) Summary
CI Configuration
.github/workflows/ci.yml
Added NGINX 1.28.1 to the nginx_version matrix in the Build Binaries job

Possibly related PRs

Suggested labels

enhancement

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add support for nginx 1.28.1' accurately and clearly summarizes the main change: adding nginx 1.28.1 to the CI build matrix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e6c0346 and fa6780c.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
🔇 Additional comments (1)
.github/workflows/ci.yml (1)

56-56: LGTM!

nginx-1.28.1 stable version has been released and includes a security fix for CVE-2025-53859 (memory disclosure in ngx_mail_smtp_module). The version is correctly positioned in the matrix between 1.28.0 and 1.29.0, following the existing format.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@abridgel
Copy link
Copy Markdown
Contributor Author

@lucacome Do you know how we can merge these changes in - we are just looking for support for 1.28.1

@abridgel
Copy link
Copy Markdown
Contributor Author

@rnburn could you approve these changes for merging?

@lucacome
Copy link
Copy Markdown
Member

Thanks @abridgel

@lucacome lucacome merged commit 2f08c41 into opentracing-contrib:master Jan 14, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants