Skip to content

ignore ErrNotDynLinked for all valgrind rpm files#270

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jctanner:IGNORE_VALGRIND
Jun 18, 2025
Merged

ignore ErrNotDynLinked for all valgrind rpm files#270
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jctanner:IGNORE_VALGRIND

Conversation

@jctanner
Copy link
Contributor

@jctanner jctanner commented Jun 18, 2025

We've encountered ErrNotDynLinked errors on valgrind with multiple RHOAI images. Given valgrind is not performing cryptographic operations, is not a golang binary and would generally not compile any differently with CGO_ENABLED=1, we'd like to make a blanket ignore on it's files.

---- Failure Report
+----------------+---------------------------+----------------------------------------------+--------------------------------------+------------------------------------+
| OPERATOR NAME  | RPM NAME                  | EXECUTABLE NAME                              | STATUS                               | IMAGE                              |
+----------------+---------------------------+----------------------------------------------+--------------------------------------+------------------------------------+
| ubi9-container | habanalabs-firmware-tools | /usr/bin/hl-smi                              | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/cachegrind-amd64-linux | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/callgrind-amd64-linux  | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/dhat-amd64-linux       | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/drd-amd64-linux        | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/exp-bbv-amd64-linux    | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/helgrind-amd64-linux   | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/lackey-amd64-linux     | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/massif-amd64-linux     | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/memcheck-amd64-linux   | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
| ubi9-container | valgrind                  | /usr/libexec/valgrind/none-amd64-linux       | executable is not dynamically linked | quay.io/modh/vllm:rhoai-2.19-gaudi |
+----------------+---------------------------+----------------------------------------------+--------------------------------------+------------------------------------+

@openshift-ci openshift-ci bot requested review from kolyshkin and rphillips June 18, 2025 15:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2025

@jctanner: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2025
error = "ErrGoMissingTag"
files = ["/usr/lib/dracut/modules.d/30ignition/ignition"]

[[rpm.valgrind.ignore]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will exclude for all OCP versions. Is that what we want or can we make this more specific to the release it's affecting by contributing it to https://github.com/openshift/check-payload/tree/main/dist/releases/4.20 for example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're encountering these failures in component images for Red Hat Openshift AI, which supports multiple OCP versions. Currently 4.14 to 4.18 per https://access.redhat.com/support/policy/updates/rhoai-sm/lifecycle ... so unfortunately can't pin this exception to specific OCP version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to add the exclusion to each affected OCP version in dist/releases then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But since this is going to be rolled forward for all new versions of OpenShift, then we can probably DRY things up by keeping this in the global config.

Thanks for walking me through this.

Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jctanner, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit fd3d30b into openshift:main Jun 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants