ignore ErrNotDynLinked for all valgrind rpm files#270
ignore ErrNotDynLinked for all valgrind rpm files#270openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
@jctanner: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
| error = "ErrGoMissingTag" | ||
| files = ["/usr/lib/dracut/modules.d/30ignition/ignition"] | ||
|
|
||
| [[rpm.valgrind.ignore]] |
There was a problem hiding this comment.
I think this will exclude for all OCP versions. Is that what we want or can we make this more specific to the release it's affecting by contributing it to https://github.com/openshift/check-payload/tree/main/dist/releases/4.20 for example?
There was a problem hiding this comment.
We're encountering these failures in component images for Red Hat Openshift AI, which supports multiple OCP versions. Currently 4.14 to 4.18 per https://access.redhat.com/support/policy/updates/rhoai-sm/lifecycle ... so unfortunately can't pin this exception to specific OCP version.
There was a problem hiding this comment.
We should be able to add the exclusion to each affected OCP version in dist/releases then.
There was a problem hiding this comment.
But since this is going to be rolled forward for all new versions of OpenShift, then we can probably DRY things up by keeping this in the global config.
Thanks for walking me through this.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jctanner, rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We've encountered ErrNotDynLinked errors on valgrind with multiple RHOAI images. Given valgrind is not performing cryptographic operations, is not a golang binary and would generally not compile any differently with CGO_ENABLED=1, we'd like to make a blanket ignore on it's files.