Skip to content

added to v4.19 and virt-handler ignore#243

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
tal-hason:cnv-fips
Feb 14, 2025
Merged

added to v4.19 and virt-handler ignore#243
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
tal-hason:cnv-fips

Conversation

@tal-hason
Copy link
Contributor

as we move to v4.19 update the config for 4.19 and added missing:

[[payload.virt-handler-rhel9-container.ignore]]
error = "ErrNotDynLinked"
files = ["/usr/bin/container-disk"]

@openshift-ci openshift-ci bot requested review from ashwindasr and rhmdnd February 4, 2025 09:05
@tal-hason tal-hason closed this Feb 5, 2025
@tal-hason tal-hason reopened this Feb 5, 2025
Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent with what was introduced in #235 - with the exception of the 4.13 and 4.18 changes.

@tal-hason
Copy link
Contributor Author

@rhmdnd , we noticed some duplicates in the v4.18 and v4.13 and fixed those

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2025

@tal-hason: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, tal-hason

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit a301069 into openshift:main Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants