add ignore to hco-bundle-registry-container#228
add ignore to hco-bundle-registry-container#228openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
Conversation
|
Is there a conversation in slack about these binaries? I'm curious why these are being disabled? |
|
@tal-hason Would removing the relevant lines in https://github.com/openshift/check-payload/blob/main/config.toml to avoid redundancy ? |
Not sure, i think it's only catching the versions, I can verify it with CVP slack |
For example, there are |
|
@tal-hason Hi Tal, thanks! Just to make sure, it's only needed in 4.13, 4.18 and 4.19? I'd suggest to update PR's description to mention it. |
From what I understood the 4.18 will effect the 4.17 4.16 4.15 and 4.14 am I correct? |
|
Hello, can this be merged? is there anything blocking? We want to make sure we fully pass FIPS checks before the warnings become failures. |
I'm not sure about this. I'd ask the maintainers of this repository. |
This is what was told here: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, tal-hason The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tal-hason: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.