Skip to content

add ignore to hco-bundle-registry-container#228

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
tal-hason:cnv-fips
Dec 16, 2024
Merged

add ignore to hco-bundle-registry-container#228
openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
tal-hason:cnv-fips

Conversation

@tal-hason
Copy link
Contributor

No description provided.

@rphillips
Copy link
Contributor

Is there a conversation in slack about these binaries? I'm curious why these are being disabled?

@dominikholler
Copy link
Contributor

@tal-hason Would removing the relevant lines in https://github.com/openshift/check-payload/blob/main/config.toml to avoid redundancy ?

@tal-hason
Copy link
Contributor Author

@tal-hason Would removing the relevant lines in https://github.com/openshift/check-payload/blob/main/config.toml to avoid redundancy ?

Not sure, i think it's only catching the versions, I can verify it with CVP slack

@codingben
Copy link

Is there a conversation in slack about these binaries? I'm curious why these are being disabled?

For example, there are *.test binaries that are not shipped to the customers, only to QE, and thus no FIPS checks needed. As for others, we just want to ignore this error (I'm pretty sure there is a reason for it in upstream).

@codingben
Copy link

@tal-hason Hi Tal, thanks! Just to make sure, it's only needed in 4.13, 4.18 and 4.19? I'd suggest to update PR's description to mention it.

@tal-hason
Copy link
Contributor Author

@tal-hason Hi Tal, thanks! Just to make sure, it's only needed in 4.13, 4.18 and 4.19? I'd suggest to update PR's description to mention it.

From what I understood the 4.18 will effect the 4.17 4.16 4.15 and 4.14
and 4.13 will effect 4.12

am I correct?

@Axuba
Copy link
Contributor

Axuba commented Dec 10, 2024

Hello, can this be merged? is there anything blocking? We want to make sure we fully pass FIPS checks before the warnings become failures.

@codingben
Copy link

@tal-hason Hi Tal, thanks! Just to make sure, it's only needed in 4.13, 4.18 and 4.19? I'd suggest to update PR's description to mention it.

From what I understood the 4.18 will effect the 4.17 4.16 4.15 and 4.14 and 4.13 will effect 4.12

am I correct?

I'm not sure about this. I'd ask the maintainers of this repository.

@tal-hason
Copy link
Contributor Author

@tal-hason Hi Tal, thanks! Just to make sure, it's only needed in 4.13, 4.18 and 4.19? I'd suggest to update PR's description to mention it.

From what I understood the 4.18 will effect the 4.17 4.16 4.15 and 4.14 and 4.13 will effect 4.12
am I correct?

I'm not sure about this. I'd ask the maintainers of this repository.

This is what was told here:
https://redhat-internal.slack.com/archives/C07TC0L7ATB/p1731420233351089?thread_ts=1731412943.825689&cid=C07TC0L7ATB

@rphillips
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, tal-hason

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@tal-hason: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bed3dbc into openshift:main Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants