Use Eventfd() from golang.org/x/sys/unix#1491
Merged
mrunalp merged 2 commits intoopencontainers:masterfrom Jun 23, 2017
tklauser:unix-eventfd
Merged
Use Eventfd() from golang.org/x/sys/unix#1491mrunalp merged 2 commits intoopencontainers:masterfrom tklauser:unix-eventfd
mrunalp merged 2 commits intoopencontainers:masterfrom
tklauser:unix-eventfd
Conversation
Update golang.org/x/sys to get the Eventfd syscall wrapper and the corresponding EFD_* flags. These will be used in a successive commit to simplify code in libcontainer/notify_linux.go. Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Use unix.Eventfd() instead of calling manually reimplementing it using the raw syscall. Also use the correct corresponding unix.EFD_CLOEXEC flag instead of unix.FD_CLOEXEC (which can have a different value on some architectures and thus might lead to unexpected behavior). Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Member
|
LGTM |
Member
|
@tklauser Thanks for working on these. It really helps. |
Contributor
|
LGTM |
Member
|
I second @crosbymichael -- thanks a lot for these @tklauser! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update golang.org/x/sys/unix to get Eventfd() and the corresponding EFD_* flags introduced in golang/sys@0b25a408) and switch libcontainer to use Eventfd() instead of manually reimplementing it. Also use the correct corresponding unix.EFD_CLOEXEC flag instead of unix.FD_CLOEXEC (which can have a different value on some architectures and thus might lead to unexpected behavior).