refactor: Centralize build paths for Android and iOS#38
Merged
niyajali merged 3 commits intoopenMF:devfrom Jan 22, 2025
Merged
Conversation
Update the cache cleanup workflow to run on ubuntu-latest and rename it to 'Cleanup Cache'. Also, the workflow is triggered on pull request close and workflow dispatch. Finally, it uses the openMF/mifos-mobile-github-actions cache cleanup action.
Update the cache cleanup workflow to run on ubuntu-latest and rename it to 'Cleanup Cache'. Also, the workflow is triggered on pull request close and workflow dispatch. Finally, it uses the openMF/mifos-mobile-github-actions cache cleanup action.
Centralized build paths for Android and iOS by moving them into dedicated configuration objects within `FastlaneConfig`. This improves code organization and maintainability. - Moved Android build paths to `FastlaneConfig::AndroidConfig::BUILD_PATHS`. - Moved iOS build paths to `FastlaneConfig::IosConfig::BUILD_CONFIG`. - Updated Fastfile lanes to use the new centralized paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the GitHub Actions workflow and the Fastlane configuration for both Android and iOS platforms. The main goal is to standardize and simplify the configuration paths and token names.
Changes to GitHub Actions workflow:
.github/workflows/cache-cleanup.yaml: Renamed the job and token name for consistency. [1] [2]Changes to Fastlane configuration:
fastlane/FastFile: Updated Android and iOS build paths to use centralized configuration constants for better maintainability and consistency. [1] [2] [3] [4] [5] [6] [7]