[CodeCamp2023-652] MMagic 新 config 体验与适配 StyleGAN3#2018
Merged
LeoXing1996 merged 9 commits intoopen-mmlab:mainfrom Sep 12, 2023
Merged
[CodeCamp2023-652] MMagic 新 config 体验与适配 StyleGAN3#2018LeoXing1996 merged 9 commits intoopen-mmlab:mainfrom
LeoXing1996 merged 9 commits intoopen-mmlab:mainfrom
Conversation
Collaborator
|
Hey @hhy150, thanks for your contribution! |
Contributor
Author
|
Verify the new and old configuration files
There are a total of 10 files here:
2. Verify all configuration files after conversion
After verifying the script, there were no errors.
In addition, I also compared the configuration files obtained by running the training dump on the new and old configs, and found that they are only different in the "type" field. The new configs have full information. Some screenshots are as follows:
…------------------ 原始邮件 ------------------
发件人: "open-mmlab/mmagic" ***@***.***>;
发送时间: 2023年9月5日(星期二) 晚上8:04
***@***.***>;
***@***.******@***.***>;
主题: Re: [open-mmlab/mmagic] [CodeCamp2023-652] MMagic 新 config 体验与适配 StyleGAN3 (PR #2018)
Hey @hhy150, thanks for your contribution!
Could you please also upload a screenshot of the output of validation script and the generated result to ensure correctness of configs?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
…into hhy150/CodeCamp2023_652_2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
(1) Changed the name of the configuration file to comply with the Python module name specification, with only letters, numbers, and underscores included in the file name.
(2) Based on the new configs run through training, observe the dump configuration file, which is not significantly different from the old configs. As described in the tutorial, only the 'type' field is different, and the new configs file will contain the full information of the module.
There are a total of 10 files:
After verifying the script, there were no errors.
In addition, I also compared the configuration files obtained by running the training dump on the new and old configs, and found that they are only different in the "type" field. The new configs have full information. Some screenshots are as follows:

BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Submitting this pull request means that,
Before PR:
After PR: