Skip to content

[Feature] Support Style-Based Global Appearance Flow for Virtual Try-On#1786

Merged
LeoXing1996 merged 18 commits intoopen-mmlab:mainfrom
FerryHuang:dev-1.x
May 5, 2023
Merged

[Feature] Support Style-Based Global Appearance Flow for Virtual Try-On#1786
LeoXing1996 merged 18 commits intoopen-mmlab:mainfrom
FerryHuang:dev-1.x

Conversation

@FerryHuang
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@Z-Fran Z-Fran changed the base branch from dev-1.x to main April 26, 2023 07:21
@LeoXing1996
Copy link
Collaborator

Hey @FerryHuang F, thanks for this great work. Since MMEdit has changed it's name to MMagic, please update your PR with newest main branch and change mmedit to mmagic in package import.

@LeoXing1996
Copy link
Collaborator

BTW, may I close PR #1781?

@FerryHuang
Copy link
Contributor Author

BTW, may I close PR #1781?

Sure it's okay to close it~

Hey @FerryHuang F, thanks for this great work. Since MMEdit has changed it's name to MMagic, please update your PR with newest main branch and change mmedit to mmagic in package import.

Thanks for your review! I hope that my PR branch has now been successfully updated with the main branch of MMagic. However, I am uncertain about how to initialize a new model using its config dict, as was done with the func init_model in the previous mmedit.apis. Should I utilize an Inferencer or do customizing Inferencer things?

@LeoXing1996
Copy link
Collaborator

@FerryHuang You can still use init_model function by

from mmagic.apis.inferencers.inference_functions import init_model

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (031576d) 83.11% compared to head (8189dd2) 83.11%.

❗ Current head 8189dd2 differs from pull request most recent head 4f5d9bf. Consider uploading reports for the commit 4f5d9bf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1786   +/-   ##
=======================================
  Coverage   83.11%   83.11%           
=======================================
  Files         410      410           
  Lines       27340    27340           
  Branches     4260     4260           
=======================================
  Hits        22723    22723           
  Misses       3704     3704           
  Partials      913      913           
Flag Coverage Δ
unittests 83.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LeoXing1996 LeoXing1996 merged commit 8551b3c into open-mmlab:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants