Skip to content

update deployment guide#1551

Merged
zengyh1900 merged 10 commits intoopen-mmlab:dev-1.xfrom
lvhan028:add-deployment-guide
Dec 26, 2022
Merged

update deployment guide#1551
zengyh1900 merged 10 commits intoopen-mmlab:dev-1.xfrom
lvhan028:add-deployment-guide

Conversation

@lvhan028
Copy link
Contributor

@lvhan028 lvhan028 commented Dec 22, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Dec 22, 2022

CLA assistant check
All committers have signed the CLA.

@zengyh1900 zengyh1900 self-requested a review December 23, 2022 05:52
@zengyh1900 zengyh1900 assigned zengyh1900 and unassigned liuwenran Dec 24, 2022
@zengyh1900
Copy link
Collaborator

I suggest using a relative path to the installation guide for mmedit since it will update asap.
LGTM after commit the suggested changes.

@zengyh1900 zengyh1900 merged commit 8746f8d into open-mmlab:dev-1.x Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants