[Enhancement] Adopt BaseModule for some models#1543
Merged
zengyh1900 merged 7 commits intoopen-mmlab:mainfrom Jul 27, 2023
Merged
[Enhancement] Adopt BaseModule for some models#1543zengyh1900 merged 7 commits intoopen-mmlab:mainfrom
BaseModule for some models#1543zengyh1900 merged 7 commits intoopen-mmlab:mainfrom
Conversation
9b707bb to
15368f9
Compare
plyfager
reviewed
Dec 19, 2022
Collaborator
plyfager
left a comment
There was a problem hiding this comment.
I'm wondering whether init_cfg is the same with the one in MMEngine. Since Configs havn't be modified yet.
10f79ca to
b298128
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1543 +/- ##
==========================================
- Coverage 82.31% 82.24% -0.07%
==========================================
Files 416 416
Lines 27966 27955 -11
Branches 4375 4372 -3
==========================================
- Hits 23020 22992 -28
- Misses 3997 4025 +28
+ Partials 949 938 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zengyh1900
requested changes
Jan 17, 2023
Collaborator
zengyh1900
left a comment
There was a problem hiding this comment.
remove tests/data/disco_result.png
b298128 to
08f143f
Compare
Z-Fran
previously approved these changes
Jan 17, 2023
08f143f to
d05ee59
Compare
Z-Fran
previously approved these changes
Feb 23, 2023
zengyh1900
previously approved these changes
Feb 23, 2023
f22240e to
30f3417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Adopt
BaseModulefor some modelsModification
Model list:
Who can help? @ them here!
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: