Skip to content

[Bug] fix extract_gt_data of realesrgan#1542

Merged
Z-Fran merged 7 commits intoopen-mmlab:dev-1.xfrom
ldr426:patch-1
Dec 22, 2022
Merged

[Bug] fix extract_gt_data of realesrgan#1542
Z-Fran merged 7 commits intoopen-mmlab:dev-1.xfrom
ldr426:patch-1

Conversation

@ldr426
Copy link
Contributor

@ldr426 ldr426 commented Dec 16, 2022

[Bug] fix extract_gt_data of realesrgan

Motivation

[Bug] fix extract_gt_data of realesrgan

Modification

real_esrgan.py line194
gt_unsharp = [data_sample.gt_unsharp.data for data_sample in data_samples]

[Bug] fix extract_gt_data of realesrgan
@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
All committers have signed the CLA.

@Z-Fran Z-Fran self-requested a review December 18, 2022 14:45
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 88.11% // Head: 88.11% // No change to project coverage 👍

Coverage data is based on head (a00465b) compared to base (11f5c2e).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head a00465b differs from pull request most recent head 951fe95. Consider uploading reports for the commit 951fe95 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           dev-1.x    #1542   +/-   ##
========================================
  Coverage    88.11%   88.11%           
========================================
  Files          386      386           
  Lines        24442    24442           
  Branches      3820     3820           
========================================
  Hits         21537    21537           
  Misses        2085     2085           
  Partials       820      820           
Flag Coverage Δ
unittests 88.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/editors/real_esrgan/real_esrgan.py 82.14% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Z-Fran Z-Fran merged commit 6182116 into open-mmlab:dev-1.x Dec 22, 2022
@openmmlab-bot
Copy link
Collaborator

Dear ldr426,
First of all, we want to express our gratitude for your significant PR in the MMEditing project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlabwx, or join in our discord:https://discord.gg/raweFPmdzG. We sincerely hope you will join us!
Best regards! @ldr426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants