Skip to content

[Enhancement] Fix text2image inferencer + disco diffusion GPU test#1523

Merged
LeoXing1996 merged 1 commit intoopen-mmlab:dev-1.xfrom
LeoXing1996:leoxing/fix-disco-and-API-ut
Dec 13, 2022
Merged

[Enhancement] Fix text2image inferencer + disco diffusion GPU test#1523
LeoXing1996 merged 1 commit intoopen-mmlab:dev-1.xfrom
LeoXing1996:leoxing/fix-disco-and-API-ut

Conversation

@LeoXing1996
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

guider.py relay torchvision.transforms > 0.7.0.

Modification

Skip unit test when torchvision.__version__ is less than or equal to 0.7.0.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@LeoXing1996 LeoXing1996 added the kind/enhancement refactoring, improving CI, template, etc. label Dec 12, 2022
@LeoXing1996 LeoXing1996 self-assigned this Dec 12, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Base: 88.04% // Head: 88.02% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3ec6128) compared to base (b2333a8).
Patch coverage: 28.57% of modified lines in pull request are covered.

❗ Current head 3ec6128 differs from pull request most recent head de45ec4. Consider uploading reports for the commit de45ec4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1523      +/-   ##
===========================================
- Coverage    88.04%   88.02%   -0.02%     
===========================================
  Files          383      383              
  Lines        24176    24183       +7     
  Branches      3793     3794       +1     
===========================================
+ Hits         21285    21287       +2     
- Misses        2076     2081       +5     
  Partials       815      815              
Flag Coverage Δ
unittests 88.02% <28.57%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/models/editors/disco_diffusion/guider.py 17.69% <28.57%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@liuwenran liuwenran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. thanks

@LeoXing1996 LeoXing1996 merged commit 112a226 into open-mmlab:dev-1.x Dec 13, 2022
@LeoXing1996 LeoXing1996 deleted the leoxing/fix-disco-and-API-ut branch December 13, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement refactoring, improving CI, template, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants