[readme] use tilde instead of hardcoded home directory "/home/user"#3799
Open
pzhlkj6612 wants to merge 2 commits intonvm-sh:masterfrom
Open
[readme] use tilde instead of hardcoded home directory "/home/user"#3799pzhlkj6612 wants to merge 2 commits intonvm-sh:masterfrom
pzhlkj6612 wants to merge 2 commits intonvm-sh:masterfrom
Conversation
For now, only "test/fast/Unit tests/nvm_change_path" uses "/home/user".
ljharb
reviewed
Mar 5, 2026
README.md
Outdated
|
|
||
| # Create a script file sourced by both interactive and non-interactive bash shells | ||
| ENV BASH_ENV /home/user/.bash_env | ||
| ENV BASH_ENV $HOME/.bash_env |
Author
There was a problem hiding this comment.
Hi!
any reason not to use
~?
My bad, it should be the same as the code lines below. Fixed in 1942ce2.
at least in this code block.
pzhlkj6612
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
A simple copy-paste produced some errors, and the hardcoded path was the cause. Just let README use
$HOMEwhen possible.