RFC: include and exclude files by shebang contents and other criteria#648
Open
tomeon wants to merge 2 commits intonumtide:mainfrom
Open
RFC: include and exclude files by shebang contents and other criteria#648tomeon wants to merge 2 commits intonumtide:mainfrom
tomeon wants to merge 2 commits intonumtide:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended for cases like scripts, which may lack extensions indicating their file/language type.
An incidental change is the introduction of the
format.Matcherinterface and various types implementing this interface. The idea is to encapsulate various bits of logic:I do not have very much experience in Go, so I'm not certain whether this approach is a good idea or, if so, whether it is implemented sensibly. The intentions are:
CompositeMatcheris a bit verbose/unwieldy, but using it is IMO straightforward -- one call toWants(path)for each path under consideration), andThanks in advance for your consideration!