fix(js): include transitive dep outputs in typecheck inputs#34773
Merged
FrozenPandaz merged 1 commit intomasterfrom Mar 10, 2026
Merged
fix(js): include transitive dep outputs in typecheck inputs#34773FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
TypeScript project references transitively read .d.ts outputs from the full dependency chain, but the inferred inputs only tracked direct deps.
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit c357c03
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Mar 10, 2026
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/js/typescriptplugin infersdependentTasksOutputFiles: '**/*.{d.ts,tsbuildinfo}'as inputs for typecheck tasks, but only tracks.d.tsoutputs from direct dependencies. TypeScript project references transitively read.d.tsfiles from the full dependency chain, so when a project typechecks, it reads.d.tsoutputs from transitive deps too. These undeclared inputs can cause incorrect cache hits.Expected Behavior
The inferred inputs for typecheck tasks include
.d.tsand.tsbuildinfooutputs from the entire transitive dependency graph by settingtransitive: trueon thedependentTasksOutputFilesinput.