fix(webpack): update e2e snapshot for vitest reportsDirectory change#34766
Merged
FrozenPandaz merged 1 commit intomasterfrom Mar 9, 2026
Merged
fix(webpack): update e2e snapshot for vitest reportsDirectory change#34766FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
The vitest reportsDirectory is now resolved against workspace root instead of project root, updating the snapshot to match.
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit e9eba7e
☁️ Nx Cloud last updated this comment at |
AgentEnder
approved these changes
Mar 9, 2026
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The webpack legacy e2e test (
e2e-webpack:e2e-ci--src/webpack.legacy.test.ts) fails with a snapshot mismatch because thereportsDirectoryvalue changed from../coverage/app3224373tocoverage/app3224373.Expected Behavior
The snapshot should match the new
reportsDirectorypath format introduced by #34720.Related Issue(s)
Fixes the e2e test breakage introduced by #34720 (
fix(vitest)!: resolve reportsDirectory against workspace root).