fix(core): ensure batch tasks always have hash for DTE by FrozenPandaz · Pull Request #34764 · nrwl/nx

FrozenPandaz · 2026-03-09T20:26:48Z

Current Behavior

After #34446, batch tasks with depsOutputs inputs had their hashing deferred until after execution. This meant the streaming endTasks callback fired with task.hash = undefined, which Cloud/DTE rejects.

Expected Behavior

All batch tasks always have a valid hash when endTasks is called. Tasks with depsOutputs get a preliminary hash upfront (based on whatever outputs are on disk), then are re-hashed after execution with fresh outputs for correct cache storage.

How it works

Phase 1 now hashes ALL root tasks at each level (not just cache-eligible ones). Ineligible tasks get a preliminary hash so the streaming callback always has something valid to send.
Phase 2 runs the batch, then clears and re-hashes all tasks that ran — outputs are fresh on disk, so depsOutputs tasks get correct final hashes.
The re-hash logic is consolidated into a single block after both code paths (cache-enabled and cache-skipped).

Related Issue(s)

Fixes the undefined hash regression from #34446

netlify · 2026-03-09T20:26:53Z

✅ Deploy Preview for nx-docs ready!

Name	Link
🔨 Latest commit	`7b2587f`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-docs/deploys/69b09b2458128e000706957d
😎 Deploy Preview	https://deploy-preview-34764--nx-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-03-09T20:26:53Z

✅ Deploy Preview for nx-dev ready!

Name	Link
🔨 Latest commit	`7b2587f`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-dev/deploys/69b09b24d3c219000841967c
😎 Deploy Preview	https://deploy-preview-34764--nx-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2026-03-09T20:27:35Z

View your CI Pipeline Execution ↗ for commit 7b2587f

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-c...`	✅ Succeeded	48m 18s	View ↗
`nx run-many -t check-imports check-lock-files c...`	✅ Succeeded	3m 22s	View ↗
`nx-cloud record -- nx-cloud conformance:check`	✅ Succeeded	8s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	1s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-10 23:25:46 UTC

github-actions · 2026-03-09T23:02:47Z

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@22.6.0-pr.34764.868a863 my-workspace

Or just copy this version and use it in your own command:

22.6.0-pr.34764.868a863

Release details	📑
Published version	22.6.0-pr.34764.868a863
Triggered by	@FrozenPandaz
Branch	fix-dte-hash
Commit	868a863
Workflow run	22877160599

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

github-actions · 2026-03-10T13:38:01Z

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@22.6.0-pr.34764.c1c3b27 my-workspace

Or just copy this version and use it in your own command:

22.6.0-pr.34764.c1c3b27

Release details	📑
Published version	22.6.0-pr.34764.c1c3b27
Triggered by	@FrozenPandaz
Branch	fix-dte-hash
Commit	c1c3b27
Workflow run	22903892842

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

github-actions · 2026-03-10T16:30:06Z

Failed to publish a PR release of this pull request, triggered by @FrozenPandaz.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/22912189086

github-actions · 2026-03-10T17:36:21Z

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@22.6.0-pr.34764.a957296 my-workspace

Or just copy this version and use it in your own command:

22.6.0-pr.34764.a957296

Release details	📑
Published version	22.6.0-pr.34764.a957296
Triggered by	@FrozenPandaz
Branch	fix-dte-hash
Commit	a957296
Workflow run	22912189086

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

github-actions · 2026-03-10T20:09:17Z

Failed to publish a PR release of this pull request, triggered by @AgentEnder.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/22920895243

github-actions · 2026-03-10T20:17:31Z

Failed to publish a PR release of this pull request, triggered by @FrozenPandaz.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/22920895243

github-actions · 2026-03-10T20:19:06Z

Failed to publish a PR release of this pull request, triggered by @FrozenPandaz.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/22919722522

github-actions · 2026-03-10T20:38:21Z

Failed to publish a PR release of this pull request, triggered by @FrozenPandaz.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/22920895243

In batch mode, Phase 2 tasks (those with depsOutputs and non-cached deps) are hashed after execution, not before. The streaming callback was calling endTasks for these tasks before they had a hash, sending undefined to Cloud which rejects null hashes on runs/end. Remove endTasks from the streaming callback entirely and let postRunSteps handle it for all batch tasks. This ensures every task has its correct final hash when Cloud/DTE receives the completion event. Also removes the now-unnecessary batchTaskResultsStreamed set.

Split streaming callback concerns: setTaskTiming + setTaskStatus for real-time TUI updates, endTasks fires once from postRunSteps after hashing so Cloud always receives correct hash values.

…ming

…er execution

…mpletion

The tui-summary lifecycle didn't need to change for the batch hash fix. Reverting to master restores the working endTasks counting logic.

Instead of deferring hashing for ineligible tasks, hash all tasks at each level (preliminary hash). Only skip cache lookup for depsOutputs tasks with non-cached deps. After execution, re-hash only those tasks so they get correct hashes based on fresh outputs on disk.

…Batches Move scheduleTask calls to after applyBatchCachedResults so tasks have valid hashes when the cloud lifecycle reads scheduledTasks. Remove the now-unused processedBatches map.

Co-authored-by: FrozenPandaz <FrozenPandaz@users.noreply.github.com>

…s-runner

github-actions · 2026-03-10T20:42:42Z

Failed to publish a PR release of this pull request, triggered by @AgentEnder.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/22920895243

github-actions · 2026-03-10T21:08:18Z

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx create-nx-workspace@22.6.0-pr.34764.07d8b15 my-workspace

Or just copy this version and use it in your own command:

22.6.0-pr.34764.07d8b15

Release details	📑
Published version	22.6.0-pr.34764.07d8b15
Triggered by	@AgentEnder
Branch	fix-dte-hash
Commit	07d8b15
Workflow run	22923371008

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

…s-runner [Self-Healing CI Rerun]

nx-cloud

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.

_{🎓 Learn more about Self-Healing CI on nx.dev}

github-actions · 2026-03-17T00:16:33Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

FrozenPandaz force-pushed the fix-dte-hash branch 3 times, most recently from 3c776e5 to 30776d5 Compare March 9, 2026 20:41

This comment was marked as outdated.

Sign in to view

FrozenPandaz force-pushed the fix-dte-hash branch from 868a863 to 533dd9f Compare March 9, 2026 22:28

This comment was marked as outdated.

Sign in to view

FrozenPandaz added 10 commits March 10, 2026 16:38

fix(core): prevent undefined hash in batch task endTasks for Cloud/DTE

aaeb999

Split streaming callback concerns: setTaskTiming + setTaskStatus for real-time TUI updates, endTasks fires once from postRunSteps after hashing so Cloud always receives correct hash values.

fix(core): include generated native TypeScript bindings for setTaskTi…

c92c153

…ming

fix(core): clear hash for batch cache misses to enable re-hashing aft…

3888098

…er execution

fix(core): update tui-summary tests to call setTaskStatus for task co…

3b72b31

…mpletion

fix(core): revert unnecessary tui-summary-life-cycle changes

af2fb82

The tui-summary lifecycle didn't need to change for the batch hash fix. Reverting to master restores the working endTasks counting logic.

fix(core): move preRunSteps after hashing and simplify batch cache flow

188f8ec

fix(core): move batch scheduleTask after hashing and remove processed…

657cc42

…Batches Move scheduleTask calls to after applyBatchCachedResults so tasks have valid hashes when the cloud lifecycle reads scheduledTasks. Remove the now-unused processedBatches map.

fix(core): complete cached batch results immediately before execution

c17e457

nx-cloud bot and others added 3 commits March 10, 2026 16:38

fix(core): fix stale results return in applyFromCacheOrRunBatch

bdcf427

Co-authored-by: FrozenPandaz <FrozenPandaz@users.noreply.github.com>

fix(core): simplify applyFromCacheOrRunBatch to return void

0cc03ce

fix(core): restore applyFromCacheOrRunBatch return type for init-task…

07d8b15

…s-runner

FrozenPandaz force-pushed the fix-dte-hash branch from 110f2d0 to 07d8b15 Compare March 10, 2026 20:40

This comment was marked as outdated.

Sign in to view

fix(core): restore applyFromCacheOrRunBatch return type for init-task…

5fbb431

…s-runner [Self-Healing CI Rerun]

nx-cloud bot reviewed Mar 10, 2026

View reviewed changes

FrozenPandaz marked this pull request as ready for review March 10, 2026 22:08

FrozenPandaz requested review from a team as code owners March 10, 2026 22:08

FrozenPandaz requested a review from AgentEnder March 10, 2026 22:08

fix(core): remove empty batch loop and simplify TaskItem timing updates

7b2587f

FrozenPandaz enabled auto-merge (squash) March 10, 2026 22:42

MaxKless approved these changes Mar 11, 2026

View reviewed changes

FrozenPandaz merged commit dcba2bf into master Mar 11, 2026
24 checks passed

FrozenPandaz deleted the fix-dte-hash branch March 11, 2026 09:51

github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2026

Conversation

FrozenPandaz commented Mar 9, 2026

Current Behavior

Expected Behavior

How it works

Related Issue(s)

Uh oh!

netlify bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-docs ready!

Uh oh!

netlify bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-dev ready!

Uh oh!

nx-cloud bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Mar 9, 2026

🐳 We have a release for that!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Mar 10, 2026

🐳 We have a release for that!

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

🐳 We have a release for that!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

github-actions bot commented Mar 10, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions bot commented Mar 10, 2026

🐳 We have a release for that!

Uh oh!

nx-cloud bot left a comment

Choose a reason for hiding this comment

Nx Cloud has identified a flaky task in your failed CI:

Uh oh!

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Mar 9, 2026 •

edited

Loading

netlify bot commented Mar 9, 2026 •

edited

Loading

nx-cloud bot commented Mar 9, 2026 •

edited

Loading