fix(core): surface clearer error when CNW hits SANDBOX_FAILED#34724
Merged
FrozenPandaz merged 1 commit intomasterfrom Mar 5, 2026
Merged
fix(core): surface clearer error when CNW hits SANDBOX_FAILED#34724FrozenPandaz merged 1 commit intomasterfrom
FrozenPandaz merged 1 commit intomasterfrom
Conversation
## Current Behavior When `npm install` fails during CNW sandbox creation (e.g. due to ~/.npm permission issues), the error message is empty because `--silent` suppresses all output including errors. Users see "Failed to install dependencies:" with no details. ## Expected Behavior The actual package manager error is now surfaced with exit code, log file path, and an actionable hint. For example: "Failed to install dependencies npm error EACCES: permission denied, mkdir ~/.npm/_cacache Exit code: 243 Log file: /tmp/.../error.log Please verify that "npm install --ignore-scripts" runs successfully in a temporary directory." ## Related Issue(s) Fixes NXC-4035
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 7380a54
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
approved these changes
Mar 5, 2026
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR surfaces install errors instead of silently failing without anything useful printed. It also records
needs_inputin the AX flow ascancelledso we account for cases where AI agents exit without recording either success, complete, or cancelled.BEFORE:
AFTER:
Notes
--silentfrom all PM install commands — sinceexecAndWaitusesexec()(captures output in memory, never shown to terminal),--silentjust suppressed error info for no benefitmaxBufferfrom default 1MB to 10MB to prevent process being killed when PMs emit verbose outputneeds_inputflow (was previously missing)CreateNxWorkspaceErrortoCnwErrorinexecAndWaitRelated Issue(s)
Fixes NXC-4035