Skip to content

fix(core): restore CNW user flow to match v22.1.3#34671

Merged
FrozenPandaz merged 1 commit intomasterfrom
NXC-4020
Mar 4, 2026
Merged

fix(core): restore CNW user flow to match v22.1.3#34671
FrozenPandaz merged 1 commit intomasterfrom
NXC-4020

Conversation

@jaysoo
Copy link
Member

@jaysoo jaysoo commented Mar 2, 2026

This PR brings our CNW experience back to previous state.

Current Behavior

The CNW prompt flow diverges from v22.1.3 in several ways:

  • Shows "Which starter do you want to use?" template prompt
  • Cloud prompt says "Try the full Nx platform?" instead of caching question
  • Preset flow uses simplified cloud prompt instead of CI provider → caching fallback
  • Completion message shows box banner with accessToken=undefined manual URL
  • Setup message includes github.com/new link not present in v22.1.3

Expected Behavior

Human-visible CNW flow identical to v22.1.3 while preserving:

  • NDJSON AI output (agentic experience)
  • --template flag (works via CLI, not surfaced in prompts)
  • Telemetry, error handling, AI agent detection

Changes:

  • Skip template prompt, go straight to preset/stack flow
  • Restore "Would you like remote caching?" with v22.1.3 wording
  • Restore CI provider → caching fallback prompt chain for preset flow
  • Pass actual nxCloud to createEmptyWorkspace so cloud token is real
  • Restore v22.1.3 completion message ("Your remote cache is almost complete.")
  • Restore v22.1.3 getNxCloudInfo signature with rawNxCloud URL visibility
  • Restore "Nx Cloud has been set up successfully" spinner text
  • Remove github.com/new link from push message

Related Issue(s)

Closes NXC-4020

@jaysoo jaysoo requested a review from a team as a code owner March 2, 2026 20:19
@jaysoo jaysoo requested a review from leosvelperez March 2, 2026 20:19
@netlify
Copy link

netlify bot commented Mar 2, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 3ae41c1
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69a835133688520008d36893
😎 Deploy Preview https://deploy-preview-34671--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Mar 2, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 3ae41c1
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69a83513cf8e1e00087b95c3
😎 Deploy Preview https://deploy-preview-34671--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Mar 2, 2026

View your CI Pipeline Execution ↗ for commit 3ae41c1

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 9m 52s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3m 25s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 8s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-04 13:52:07 UTC

The CNW prompt flow diverges from v22.1.3 in several ways:
- Shows "Which starter do you want to use?" template prompt
- Cloud prompt says "Try the full Nx platform?" instead of caching question
- Preset flow uses simplified cloud prompt instead of CI provider → caching fallback
- Completion message shows box banner with `accessToken=undefined` manual URL
- Setup message includes `github.com/new` link not present in v22.1.3

Human-visible CNW flow identical to v22.1.3 while preserving:
- NDJSON AI output (agentic experience)
- `--template` flag (works via CLI, not surfaced in prompts)
- Telemetry, error handling, AI agent detection

Changes:
- Skip template prompt, go straight to preset/stack flow
- Restore "Would you like remote caching?" with v22.1.3 wording
- Restore CI provider → caching fallback prompt chain for preset flow
- Pass actual nxCloud to createEmptyWorkspace so cloud token is real
- Restore v22.1.3 completion message ("Your remote cache is almost complete.")
- Restore v22.1.3 getNxCloudInfo signature with rawNxCloud URL visibility
- Restore "Nx Cloud has been set up successfully" spinner text
- Remove github.com/new link from push message

Fixes NXC-4020
@FrozenPandaz FrozenPandaz merged commit dd1c729 into master Mar 4, 2026
24 checks passed
@FrozenPandaz FrozenPandaz deleted the NXC-4020 branch March 4, 2026 14:44
FrozenPandaz pushed a commit that referenced this pull request Mar 4, 2026
This PR brings our CNW experience back to previous state.

## Current Behavior

The CNW prompt flow diverges from v22.1.3 in several ways:
- Shows "Which starter do you want to use?" template prompt
- Cloud prompt says "Try the full Nx platform?" instead of caching
question
- Preset flow uses simplified cloud prompt instead of CI provider →
caching fallback
- Completion message shows box banner with `accessToken=undefined`
manual URL
- Setup message includes `github.com/new` link not present in v22.1.3

## Expected Behavior

Human-visible CNW flow identical to v22.1.3 while preserving:
- NDJSON AI output (agentic experience)
- `--template` flag (works via CLI, not surfaced in prompts)
- Telemetry, error handling, AI agent detection

Changes:
- Skip template prompt, go straight to preset/stack flow
- Restore "Would you like remote caching?" with v22.1.3 wording
- Restore CI provider → caching fallback prompt chain for preset flow
- Pass actual nxCloud to createEmptyWorkspace so cloud token is real
- Restore v22.1.3 completion message ("Your remote cache is almost
complete.")
- Restore v22.1.3 getNxCloudInfo signature with rawNxCloud URL
visibility
- Restore "Nx Cloud has been set up successfully" spinner text
- Remove github.com/new link from push message

## Related Issue(s)

Closes NXC-4020

(cherry picked from commit dd1c729)
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants