fix(core): preserve nxCloud=skip in non-interactive CNW mode#34616
Merged
fix(core): preserve nxCloud=skip in non-interactive CNW mode#34616
Conversation
The recent change in feat(core): add explicit cloud opt-out to CNW remapped the 'skip' cloud choice to nxCloud='yes' with skipCloudConnect=true. This caused setupCI() to run in non-interactive mode, generating .github/workflows/ci.yml in new workspaces where it previously did not. This broke the extras e2e snapshot test. Restore the original behavior by keeping nxCloud='skip' when the cloud choice is 'skip', which prevents CI file generation.
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 11ae924
☁️ Nx Cloud last updated this comment at |
jaysoo
approved these changes
Feb 26, 2026
FrozenPandaz
added a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior After #34580, `determineNxCloudV2()` returns `'skip'` in non-interactive mode, but the caller remaps it to `nxCloud = 'yes'` with `skipCloudConnect = true`. This causes `setupCI()` to run and generate `.github/workflows/ci.yml` in new workspaces — which didn't happen before. This breaks the `extras.test.ts` e2e snapshot test because `.github/workflows/ci.yml` now appears in the expanded default task inputs. ## Expected Behavior Keep `nxCloud = 'skip'` when the cloud choice is `'skip'`, which prevents CI file generation in non-interactive mode. This restores the behavior prior to #34580. ## Related Issue(s) Fixes the `extras.test.ts` e2e snapshot failure introduced by #34580. (cherry picked from commit fcf4660)
FrozenPandaz
added a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior After #34580, `determineNxCloudV2()` returns `'skip'` in non-interactive mode, but the caller remaps it to `nxCloud = 'yes'` with `skipCloudConnect = true`. This causes `setupCI()` to run and generate `.github/workflows/ci.yml` in new workspaces — which didn't happen before. This breaks the `extras.test.ts` e2e snapshot test because `.github/workflows/ci.yml` now appears in the expanded default task inputs. ## Expected Behavior Keep `nxCloud = 'skip'` when the cloud choice is `'skip'`, which prevents CI file generation in non-interactive mode. This restores the behavior prior to #34580. ## Related Issue(s) Fixes the `extras.test.ts` e2e snapshot failure introduced by #34580. (cherry picked from commit fcf4660)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
After #34580,
determineNxCloudV2()returns'skip'in non-interactive mode, but the caller remaps it tonxCloud = 'yes'withskipCloudConnect = true. This causessetupCI()to run and generate.github/workflows/ci.ymlin new workspaces — which didn't happen before.This breaks the
extras.test.tse2e snapshot test because.github/workflows/ci.ymlnow appears in the expanded default task inputs.Expected Behavior
Keep
nxCloud = 'skip'when the cloud choice is'skip', which prevents CI file generation in non-interactive mode. This restores the behavior prior to #34580.Related Issue(s)
Fixes the
extras.test.tse2e snapshot failure introduced by #34580.