fix(core): use scoped cache key for unresolved npm imports in TargetProjectLocator#34605
Merged
FrozenPandaz merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
…ProjectLocator
The npmResolutionCache lookups use `${packageName}__${dirPath}` keys,
but negative-path writes used bare `importExpr`. This meant the negative
cache was never hit, causing redundant resolution work for unresolvable
imports. Also remove dead cache write for builtin module imports.
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit d3419da
☁️ Nx Cloud last updated this comment at |
leosvelperez
changed the title
FrozenPandaz
approved these changes
Feb 25, 2026
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
…rojectLocator (#34605) ## Current Behavior `TargetProjectLocator.findProjectFromImport` stores `null` for unresolved imports using a bare `importExpr` key, but `findNpmProjectFromImport` looks up cache entries using `${packageName}__${dirPath}`. The key mismatch means repeated lookups for the same import+directory re-run the full resolution waterfall (typescript + require.resolve) instead of returning the cached `null`. ## Expected Behavior Store `null` for unresolved imports using the same `${packageName}__${dirPath}` key that `findNpmProjectFromImport` uses for lookups. Repeated lookups for already-failed imports skip the expensive resolution steps. Also removes an unused cache write for builtin module imports as a minor cleanup. (cherry picked from commit 098a830)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
…rojectLocator (#34605) ## Current Behavior `TargetProjectLocator.findProjectFromImport` stores `null` for unresolved imports using a bare `importExpr` key, but `findNpmProjectFromImport` looks up cache entries using `${packageName}__${dirPath}`. The key mismatch means repeated lookups for the same import+directory re-run the full resolution waterfall (typescript + require.resolve) instead of returning the cached `null`. ## Expected Behavior Store `null` for unresolved imports using the same `${packageName}__${dirPath}` key that `findNpmProjectFromImport` uses for lookups. Repeated lookups for already-failed imports skip the expensive resolution steps. Also removes an unused cache write for builtin module imports as a minor cleanup. (cherry picked from commit 098a830)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
TargetProjectLocator.findProjectFromImportstoresnullfor unresolved imports using a bareimportExprkey, butfindNpmProjectFromImportlooks up cache entries using${packageName}__${dirPath}. The key mismatch means repeated lookups for the same import+directory re-run the full resolution waterfall (typescript + require.resolve) instead of returning the cachednull.Expected Behavior
Store
nullfor unresolved imports using the same${packageName}__${dirPath}key thatfindNpmProjectFromImportuses for lookups. Repeated lookups for already-failed imports skip the expensive resolution steps.Also removes an unused cache write for builtin module imports as a minor cleanup.