fix(angular-rspack): stats serialization and configuration#34155
Merged
Coly010 merged 2 commits intonrwl:masterfrom Jan 21, 2026
Merged
fix(angular-rspack): stats serialization and configuration#34155Coly010 merged 2 commits intonrwl:masterfrom
Coly010 merged 2 commits intonrwl:masterfrom
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coly010
approved these changes
Jan 20, 2026
Contributor
|
View your CI Pipeline Execution ↗ for commit b5026f4
☁️ Nx Cloud last updated this comment at |
Contributor
|
Hey @faileon The merge of one of the other PRs has led to a conflict here :) |
Contributor
Author
I have resolved the merge conflicts and pushed an update to my forked repo. |
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
statsValue.toJson()is called with no options, causing full serialization of all stats data on every build. This is expensive and unnecessary when only budget checking is needed.rspackConfigOverridesis not respected by the stats logger.rspackStatsLoggercallsstats.toJson()without passing the stats options, ignoring user preferences.Expected Behavior
assetsandchunks), significantly reducing overhead.toJson()entirely.rspackStatsLoggeruses the providedstatOptionswhen serializing stats.Related Issue(s)
Fixes #34145