fix(angular-rspack): handler accumulation and watchOptions for double rebuilds#34154
Merged
Coly010 merged 1 commit intonrwl:masterfrom Jan 20, 2026
Merged
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 18d727b
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Jan 20, 2026
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
compilation,beforeCompile, anddonehooks are registered insidewatchRun, causing new handlers to be added on every rebuild cycle. This leads to performance degradation and duplicate operations during watch mode.Expected Behavior
watchRunto prevent accumulation. Shared state is used to pass data between watch cycles and compilation hooks.aggregateTimeout: 50batches rapid filesystem events to prevent double rebuilds.watchOptionsto configure watcher behavior, with user options taking precedence over defaults.Related Issue(s)
#34142 (comment)