Skip to content

fix(module-federation): pin rspack to 1.6.8#34022

Merged
jaysoo merged 1 commit intomasterfrom
pin-rspack-version
Jan 6, 2026
Merged

fix(module-federation): pin rspack to 1.6.8#34022
jaysoo merged 1 commit intomasterfrom
pin-rspack-version

Conversation

@Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 5, 2026

Current Behavior

Rspack 1.7.0 is failing to create factories for internals with Module Federation.

Expected Behavior

Pin Rspack to 1.6.8 for now to ensure continued functioning of Module Federation

@Coly010 Coly010 requested review from a team, FrozenPandaz and vsavkin as code owners January 5, 2026 16:39
@Coly010 Coly010 self-assigned this Jan 5, 2026
@vercel
Copy link

vercel bot commented Jan 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nx-dev Ready Ready Preview Jan 6, 2026 10:46am

@netlify
Copy link

netlify bot commented Jan 5, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit b5a33c4
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/695ce6239340cd0008b7a0cf
😎 Deploy Preview https://deploy-preview-34022--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Jan 5, 2026

View your CI Pipeline Execution ↗ for commit b5a33c4

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 8m 28s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 1m 48s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 7s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-06 10:52:04 UTC

nx-cloud[bot]

This comment was marked as outdated.

nx-cloud[bot]

This comment was marked as outdated.

@Coly010 Coly010 requested review from a team as code owners January 5, 2026 17:19
nx-cloud[bot]

This comment was marked as outdated.

Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

Nx Cloud View detailed reasoning in Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@Coly010 Coly010 force-pushed the pin-rspack-version branch from 1485fff to b5a33c4 Compare January 6, 2026 10:38
@Coly010 Coly010 removed the request for review from a team January 6, 2026 10:38
@jaysoo jaysoo disabled auto-merge January 6, 2026 14:55
@jaysoo jaysoo enabled auto-merge (squash) January 6, 2026 14:55
@jaysoo jaysoo disabled auto-merge January 6, 2026 15:00
@jaysoo jaysoo merged commit 0119275 into master Jan 6, 2026
20 checks passed
@jaysoo jaysoo deleted the pin-rspack-version branch January 6, 2026 15:00
@github-actions
Copy link
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants