fix(js): avoid duplicate @nx/js/typescript plugin entries for non-buildable libs#34021
fix(js): avoid duplicate @nx/js/typescript plugin entries for non-buildable libs#34021leosvelperez merged 1 commit intomasterfrom
@nx/js/typescript plugin entries for non-buildable libs#34021Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 8677913
☁️ Nx Cloud last updated this comment at |
| } | ||
| } | ||
|
|
||
| export function ensureProjectIsExcludedFromPluginRegistrations( |
There was a problem hiding this comment.
This function was unused.
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.
🎓 Learn more about Self-Healing CI on nx.dev
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
2 participants
Current Behavior
When adding a non-buildable JS library (
bundler: 'none') to a workspace with an existing@nx/js/typescriptplugin registration that has build options configured, a duplicate plugin entry is unnecessarily created innx.json.Expected Behavior
Non-buildable libraries reuse the existing plugin registration when
skipBuildCheck: trueis not specified, thereby avoiding duplicate entries innx.json. The@nx/js/typescriptplugin will infer the project as non-buildable because the library'spackage.jsonwill have entry points pointing to source files, so there's no need for a separate plugin registration.Related Issue(s)
Fixes #33981