fix(testing): ensure jest v30 migration is run#33916
Merged
FrozenPandaz merged 1 commit intomasterfrom Dec 18, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
View your CI Pipeline Execution ↗ for commit 5cddeed
☁️ Nx Cloud last updated this comment at |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
FrozenPandaz
approved these changes
Dec 18, 2025
jaysoo
pushed a commit
that referenced
this pull request
Dec 19, 2025
## Current Behavior The `replace-removed-matcher-aliases` migration from `@nx/jest` is not run when migrating to Angular v21 (and updating Jest to v30). That migration targets the original package update for Jest v30 (Nx 21.3.0), which was incompatible with Angular < 21, so it wouldn't have run for Angular workspaces at the time. Now that Angular is being updated to v21, Jest is updated to v30, but the migration generator is not running. ## Expected Behavior The `replace-removed-matcher-aliases` migration from `@nx/jest` should run when migrating to Angular v21 (and updating Jest to v30).
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
replace-removed-matcher-aliasesmigration from@nx/jestis not run when migrating to Angular v21 (and updating Jest to v30). That migration targets the original package update for Jest v30 (Nx 21.3.0), which was incompatible with Angular < 21, so it wouldn't have run for Angular workspaces at the time. Now that Angular is being updated to v21, Jest is updated to v30, but the migration generator is not running.Expected Behavior
The
replace-removed-matcher-aliasesmigration from@nx/jestshould run when migrating to Angular v21 (and updating Jest to v30).