feat(core): add explicit cloud opt-out to CNW#34580
Merged
FrozenPandaz merged 1 commit intomasterfrom Feb 25, 2026
Merged
Conversation
The CNW cloud prompt previously only offered Yes/Skip, making it impossible to distinguish "not now" from "never." This adds a third option so we can respect user intent and stop prompting opted-out users. Prompt choices: Yes / Skip for now / No, don't ask again - Yes: connects workspace to Nx Cloud (writes nxCloudId to nx.json) - Skip for now: deferred connection, shows setup URL (existing behavior) - No, don't ask again: sets neverConnectToCloud: true in nx.json, suppresses all cloud messaging CLI: --nxCloud=yes|skip|never. Non-interactive defaults to skip. Also fixes "set up" → "setup" typo in completion banner.
✅ Deploy Preview for nx-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 8e004b5
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Feb 25, 2026
FrozenPandaz
approved these changes
Feb 25, 2026
FrozenPandaz
approved these changes
Feb 25, 2026
FrozenPandaz
added a commit
that referenced
this pull request
Feb 26, 2026
After #34580, non-interactive CNW generates .github/workflows/ci.yml, which gets picked up by sharedGlobals in the expanded task inputs. Update the snapshot to reflect this.
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior The CNW cloud prompt is locked to auto-select deferred connection (CLOUD-4255), always generating a short URL but never writing nxCloudId to nx.json. Users have no explicit choice. ## Expected Behavior The cloud prompt now offers three explicit choices: - Yes: connect now, generate nxCloudId in nx.json, show strong completion message - Skip for now: deferred connection (no nxCloudId), still show short URL and update README - No: full opt-out, set neverConnectToCloud: true in nx.json, no URL, no README update, no cloud messaging **CLI args:** `--nxCloud=skip`, `--nxCloud=never` (new), `--nxCloud=yes`. Non-interactive defaults to skip. Closes CLOUD-4242 (cherry picked from commit f7e46e3)
jaysoo
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior After #34580, `determineNxCloudV2()` returns `'skip'` in non-interactive mode, but the caller remaps it to `nxCloud = 'yes'` with `skipCloudConnect = true`. This causes `setupCI()` to run and generate `.github/workflows/ci.yml` in new workspaces — which didn't happen before. This breaks the `extras.test.ts` e2e snapshot test because `.github/workflows/ci.yml` now appears in the expanded default task inputs. ## Expected Behavior Keep `nxCloud = 'skip'` when the cloud choice is `'skip'`, which prevents CI file generation in non-interactive mode. This restores the behavior prior to #34580. ## Related Issue(s) Fixes the `extras.test.ts` e2e snapshot failure introduced by #34580.
FrozenPandaz
added a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior After #34580, `determineNxCloudV2()` returns `'skip'` in non-interactive mode, but the caller remaps it to `nxCloud = 'yes'` with `skipCloudConnect = true`. This causes `setupCI()` to run and generate `.github/workflows/ci.yml` in new workspaces — which didn't happen before. This breaks the `extras.test.ts` e2e snapshot test because `.github/workflows/ci.yml` now appears in the expanded default task inputs. ## Expected Behavior Keep `nxCloud = 'skip'` when the cloud choice is `'skip'`, which prevents CI file generation in non-interactive mode. This restores the behavior prior to #34580. ## Related Issue(s) Fixes the `extras.test.ts` e2e snapshot failure introduced by #34580. (cherry picked from commit fcf4660)
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior The CNW cloud prompt is locked to auto-select deferred connection (CLOUD-4255), always generating a short URL but never writing nxCloudId to nx.json. Users have no explicit choice. ## Expected Behavior The cloud prompt now offers three explicit choices: - Yes: connect now, generate nxCloudId in nx.json, show strong completion message - Skip for now: deferred connection (no nxCloudId), still show short URL and update README - No: full opt-out, set neverConnectToCloud: true in nx.json, no URL, no README update, no cloud messaging **CLI args:** `--nxCloud=skip`, `--nxCloud=never` (new), `--nxCloud=yes`. Non-interactive defaults to skip. Closes CLOUD-4242 (cherry picked from commit f7e46e3)
FrozenPandaz
added a commit
that referenced
this pull request
Feb 26, 2026
## Current Behavior After #34580, `determineNxCloudV2()` returns `'skip'` in non-interactive mode, but the caller remaps it to `nxCloud = 'yes'` with `skipCloudConnect = true`. This causes `setupCI()` to run and generate `.github/workflows/ci.yml` in new workspaces — which didn't happen before. This breaks the `extras.test.ts` e2e snapshot test because `.github/workflows/ci.yml` now appears in the expanded default task inputs. ## Expected Behavior Keep `nxCloud = 'skip'` when the cloud choice is `'skip'`, which prevents CI file generation in non-interactive mode. This restores the behavior prior to #34580. ## Related Issue(s) Fixes the `extras.test.ts` e2e snapshot failure introduced by #34580. (cherry picked from commit fcf4660)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The CNW cloud prompt is locked to auto-select deferred connection (CLOUD-4255), always generating a short URL but never writing nxCloudId to nx.json. Users have no explicit choice.
Expected Behavior
The cloud prompt now offers three explicit choices:
CLI args:
--nxCloud=skip,--nxCloud=never(new),--nxCloud=yes. Non-interactive defaults to skip.Closes CLOUD-4242