Never return None in ooxml's _parseinfo#88
Merged
nolze merged 1 commit intonolze:masterfrom May 2, 2024
gdesmar:patch-1
Merged
Never return None in ooxml's _parseinfo#88nolze merged 1 commit intonolze:masterfrom gdesmar:patch-1
nolze merged 1 commit intonolze:masterfrom
gdesmar:patch-1
Conversation
Owner
|
Thanks! Much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case where we are handling a corrupted file, the EncryptionInfo could be versionMajor 0 and versionMinor 0. In that case, the code ends up returning None, which then tries to get unpacked into two objects for self.type and self.info. By always throwing and exception, it should cover the case where the code doesn't handle the specified EncryptionInfo version.