feat: added direction css property#2529
Closed
hasanparasteh wants to merge 3 commits intoniklasvh:masterfrom
Closed
feat: added direction css property#2529hasanparasteh wants to merge 3 commits intoniklasvh:masterfrom
hasanparasteh wants to merge 3 commits intoniklasvh:masterfrom
Conversation
Owner
|
This PR parses the |
Author
|
Yes. I just added direction property... now when you said it I realized that I forgot to apply it to |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
When I wanted to use jsPdf, html2pdf.js and etc, there was a problem with RTL text direction in rendering process. So this PR should add support to direction property for
CanvasRenderingContext2D.directionand fix the problem.I also created a reftests to demonstrate the problem and showing the issue is existing.