Skip to content

feat: added direction css property#2529

Closed
hasanparasteh wants to merge 3 commits intoniklasvh:masterfrom
hasanparasteh:master
Closed

feat: added direction css property#2529
hasanparasteh wants to merge 3 commits intoniklasvh:masterfrom
hasanparasteh:master

Conversation

@hasanparasteh
Copy link
Copy Markdown

@hasanparasteh hasanparasteh commented May 11, 2021

Summary

This PR fixes/implements the following bugs/features

When I wanted to use jsPdf, html2pdf.js and etc, there was a problem with RTL text direction in rendering process. So this PR should add support to direction property for CanvasRenderingContext2D.direction and fix the problem.

I also created a reftests to demonstrate the problem and showing the issue is existing.

@niklasvh
Copy link
Copy Markdown
Owner

niklasvh commented Jul 4, 2021

This PR parses the direction property from CSS but never applies it to the CanvasRenderingContext2D.direction property?

@hasanparasteh
Copy link
Copy Markdown
Author

hasanparasteh commented Jul 4, 2021

Yes. I just added direction property... now when you said it I realized that I forgot to apply it to CanvasRenderingContext2D.direction😅. I really wanted to fix the #2488 issue and this is what I came with to help me do the task I need. I think this PR needs more work to cover up the whole RTL problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RTL direction problem

2 participants