Merged
Conversation
edmundmiller
approved these changes
Nov 20, 2024
Contributor
edmundmiller
left a comment
edmundmiller
left a comment
There was a problem hiding this comment.
I love watching a pipeline get built in this post nf-test, and all the other tooling things era 😍
| params { | ||
| input = "${projectDir}/assets/genomes/test/pipelines/default.yml" | ||
| outdir = "$outputDir" | ||
| tools = 'bowtie,bowtie2,faidx,hisat2,hisat2_extractsplicesites,kallisto,make_transcripts_fasta,rsem_preparereference_genome,salmon,star' |
Contributor
There was a problem hiding this comment.
Should we break these out into their own params? I feel like it'll be easy to miss one with this long of a string.
Contributor
There was a problem hiding this comment.
I can't remember if you can check these at the schema level like this? I think that's what happen in Demultiplex right?
Member
Author
There was a problem hiding this comment.
We can decide later at some point, but I'd rather have a single params for these than multiple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).