Skip to content

Bump deseq2/differential for check.names fix#75

Merged
apeltzer merged 2 commits intonf-core:devfrom
healx:fix_deseq2_namecheck
Feb 22, 2023
Merged

Bump deseq2/differential for check.names fix#75
apeltzer merged 2 commits intonf-core:devfrom
healx:fix_deseq2_namecheck

Conversation

@pinin4fjords
Copy link
Copy Markdown
Member

@pinin4fjords pinin4fjords commented Feb 22, 2023

Just integrating the fix from nf-core/modules#2911

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 22, 2023

nf-core lint overall result: Passed ✅

Posted for pipeline commit ab927df

+| ✅ 158 tests passed       |+
Details

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-02-22 11:55:15

Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will report back before merging if this fixed the found issue 👍🏻

@apeltzer apeltzer merged commit 342198e into nf-core:dev Feb 22, 2023
@pinin4fjords pinin4fjords deleted the fix_deseq2_namecheck branch February 22, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants