Skip to content

Release v1.0.1#49

Merged
pinin4fjords merged 7 commits intonf-core:devfrom
healx:release_v1.0.1
Jan 24, 2023
Merged

Release v1.0.1#49
pinin4fjords merged 7 commits intonf-core:devfrom
healx:release_v1.0.1

Conversation

@pinin4fjords
Copy link
Copy Markdown
Member

@pinin4fjords pinin4fjords commented Jan 24, 2023 •
edited
Loading

This PR is mostly an excuse to re-trigger (with the subsequent dev -> master merge) the pipeline release CI that will create a Zenodo entry (since the functionality wasn't enabled at first release, something we've fixed in the docs).

But It comprises:

  • Credit for Healx (my employer) as the effective main sponsor of this workflow (note: text there is the company preferred boilerplate, and I'd like to retain it if possible).
  • A version bump for this 1.0.1 release
  • Added missing logos to the schema
  • Some additional notes in output.md
  • Harrmonised some clashing citations (though in my defence I copied most of them in from other workflows- we should probably do better with citation formatting overall)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 24, 2023

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @pinin4fjords,

It looks like this pull-request is has been made against the healx/nf-core-differentialabundance master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the healx/nf-core-differentialabundance dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 42b7dcd

+| ✅ 156 tests passed       |+
!| ❗   3 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '1.0.1'
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-01-24 14:40:14

@pinin4fjords pinin4fjords changed the base branch from master to dev January 24, 2023 12:59
jfy133
jfy133 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citations: DeSeq2 doesn't have the year in the right place,

but once that's fixed good to go with your second release procedure in two days ;)

@pinin4fjords
Copy link
Copy Markdown
Member Author

pinin4fjords commented Jan 24, 2023

Thanks @apeltzer @jfy133 !

@pinin4fjords pinin4fjords merged commit 6e97660 into nf-core:dev Jan 24, 2023
@pinin4fjords pinin4fjords deleted the release_v1.0.1 branch January 24, 2023 14:49
This was referenced Jan 24, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeltzer apeltzer apeltzer approved these changes

@jfy133 jfy133 jfy133 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pinin4fjords @apeltzer @jfy133