Skip to content

Minor fixes for release 1.5.0, update changelog#267

Merged
WackerO merged 2 commits intonf-core:devfrom
WackerO:dev
May 8, 2024
Merged

Minor fixes for release 1.5.0, update changelog#267
WackerO merged 2 commits intonf-core:devfrom
WackerO:dev

Conversation

@WackerO
Copy link
Copy Markdown
Collaborator

@WackerO WackerO commented May 8, 2024

Fix whitespace and TODO, update changelog

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 8, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3ec9d1e

+| ✅ 268 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.5.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-05-08 08:36:20

@WackerO WackerO merged commit 1c4158e into nf-core:dev May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants