Skip to content

Fix logging for dendrograms#183

Merged
pinin4fjords merged 5 commits intodevfrom
fix_log_dendro
Oct 26, 2023
Merged

Fix logging for dendrograms#183
pinin4fjords merged 5 commits intodevfrom
fix_log_dendro

Conversation

@pinin4fjords
Copy link
Copy Markdown
Member

@pinin4fjords pinin4fjords commented Oct 24, 2023

This is a fix for an issue flagged by the full tests- we forgot to apply conditional logging appropriately.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@pinin4fjords pinin4fjords requested a review from WackerO October 24, 2023 22:42
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 24, 2023

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @pinin4fjords,

It looks like this pull-request is has been made against the nf-core/differentialabundance master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/differentialabundance dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 24, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 2c86611

+| ✅ 160 tests passed       |+
Details

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-26 08:09:10

WackerO
WackerO approved these changes Oct 25, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@WackerO WackerO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch!

@pinin4fjords pinin4fjords changed the base branch from master to dev October 25, 2023 09:24
@pinin4fjords pinin4fjords merged commit 8f1be52 into dev Oct 26, 2023
@pinin4fjords pinin4fjords deleted the fix_log_dendro branch October 26, 2023 08:21
@pinin4fjords pinin4fjords mentioned this pull request Oct 26, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WackerO WackerO WackerO approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pinin4fjords @WackerO