Revert accidental Muon optimizer code re-introduction from copilot PRs#6
Merged
nathon-lee merged 2 commits intomasterfrom Mar 6, 2026
Merged
Conversation
This reverts commit b90aee5.
Copilot
AI
changed the title
[WIP] Remove specific commits from master
Revert accidental Muon optimizer code re-introduction from copilot PRs
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three copilot-generated commits (
001f77c3,b90aee5a,b6da9afd) were merged into master that re-introduced partial Muon optimizer scaffolding (uses_muonattribute,reduce_scatterincompatibility assertion, modifiedaverage_tensorconditional) that had been intentionally removed byff886701.Changes
deepspeed/runtime/zero/stage_1_and_2.py: Revertsb90aee5aviagit revert, removing:self.uses_muonbroad param-group scan in__init__assert Falseguard blockingreduce_scatter=Truewith Muonany(self.group_uses_muon)branch in theaverage_tensorall-reduce pathThe per-parameter Muon logic (
muon_update,use_muonattribute checks) added by the fork's own commits is unaffected.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.