fix(bandcamp): remove warning on releases with video links#850
Open
rrrnld wants to merge 1 commit intomurdos:masterfrom
Open
fix(bandcamp): remove warning on releases with video links#850rrrnld wants to merge 1 commit intomurdos:masterfrom
rrrnld wants to merge 1 commit intomurdos:masterfrom
Conversation
rrrnld
force-pushed
the
fix/bandcamp-track-warning
branch
from
e89a526 to
2ea2d59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see e.g. https://wearearmsandsleepers.bandcamp.com/album/former-kingdoms
the meta tag that's currently used to detect the complete number of tracks is not reliable.
i'm not sure about the different places to test this. i'm also not sure when the linked data was added and if it's available for all releases, but it seems like relying on it globally could remove a lot of the parsing logic from the bandcamp importer and simplify it a lot.