polish(fxa-react): Fix eslint in fxa-react#19534
Merged
Conversation
vbudhram
approved these changes
Oct 2, 2025
Contributor
vbudhram
left a comment
vbudhram
left a comment
There was a problem hiding this comment.
@dschom LGTM, almost fixed them all
/home/circleci/project/********/fxa-react/components/AppErrorDialog/index.stories.tsx
1:1 error missing header header/header
/home/circleci/project/********/fxa-react/components/AppErrorDialog/index.tsx
5:17 error 'ReactNode' is defined but never used @typescript-eslint/no-unused-vars
✖ 2 problems (2 errors, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option.
dschom
force-pushed
the
fix-fxa-react-eslint
branch
from
9c46cad to
a19ccfd
Compare
4 tasks
Because: - The eslintrc.json didn't match fxa-settings eslintrc.json - The prettier rules and the previous eslintrc.json rules conflicted This Commit: - Applies the eslintrc.json config in settings to fxa-react - Fixes all the problems...
dschom
force-pushed
the
fix-fxa-react-eslint
branch
from
a19ccfd to
f48996f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
I ran into these problems while working on #19531.