fix(mfa): fix can't dismiss mfa guard for ARK delete#19519
Merged
MagentaManifold merged 1 commit intomainfrom Sep 30, 2025
Merged
fix(mfa): fix can't dismiss mfa guard for ARK delete#19519MagentaManifold merged 1 commit intomainfrom
MagentaManifold merged 1 commit intomainfrom
Conversation
Because: * can't dismiss mfa guard for ARK delete This commit: * makes mfa guard for ARK delete dismissable. Closes #FXA-12470
MagentaManifold
commented
Sep 29, 2025
| <MfaGuard requiredScope="recovery_key"> | ||
| <MfaGuard | ||
| requiredScope="recovery_key" | ||
| onDismissCallback={async () => hideModal()} |
Contributor
Author
There was a problem hiding this comment.
I had to wrap it because the return type must be Promise<void>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12470
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.