Skip to content

fix(perf): change css link tag's initial rel attr to preload#19006

Merged
chenba merged 1 commit intomainfrom
FXA-11759
Jun 13, 2025
Merged

fix(perf): change css link tag's initial rel attr to preload#19006
chenba merged 1 commit intomainfrom
FXA-11759

Conversation

@chenba
Copy link
Contributor

@chenba chenba commented Jun 10, 2025

Because:

  • we don't want the CSS request to block rendering

This commit:

  • change the link tag's initial rel to preload and switch to stylesheet
    on page load

@chenba chenba requested a review from a team as a code owner June 10, 2025 20:50
@chenba
Copy link
Contributor Author

chenba commented Jun 10, 2025

Note that this PR includes the commit from #19004. The original PR was also reverted with #18955 because I believe that it broke stage. I made the changes in #19004 to verify the patch in this PR and it appeared to work.

Because:
 - we don't want the CSS request to block rendering

This commit:
 - change the link tag's initial rel to preload and switch to stylesheet
   on page load
@chenba
Copy link
Contributor Author

chenba commented Jun 12, 2025

@vbudhram since you reviewed #18933, wanna rubber stamp this one? The code hasn't changed. But I re-verify it after #19004.

@chenba chenba merged commit 7abfe51 into main Jun 13, 2025
19 checks passed
@chenba chenba deleted the FXA-11759 branch June 13, 2025 15:00
@chenba chenba restored the FXA-11759 branch June 13, 2025 18:36
@chenba chenba deleted the FXA-11759 branch June 13, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants